Skip to content

CNDB-18137 fix linter warnings in files effected by CNDB-15608 - #2453

Merged
k-rus merged 6 commits into
mainfrom
rf-18137-fix-warnings
Jul 10, 2026
Merged

CNDB-18137 fix linter warnings in files effected by CNDB-15608#2453
k-rus merged 6 commits into
mainfrom
rf-18137-fix-warnings

Conversation

@k-rus

@k-rus k-rus commented Jun 12, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Fixes https://github.com/riptano/cndb/issues/18137

Fixes IntelliJ linter warnings in files affected during work on
CNDB-15608 to reduce warning noise:

  • Fix single character strings to character constants
  • Remove unused imports
  • Remove unnecessary throw in method declarations
  • Simplify assert in a test
  • Remove undocumented fields from javadoc
  • Remove unnecessary resource suppression
  • Simplify string join
  • Remove unused logger field
  • Remove unnecessary curly braces in lambda expression
  • Remove unnecessary cast

@github-actions

github-actions Bot commented Jun 12, 2026 •
edited by k-rus
Loading

Copy link
Copy Markdown

Checklist before you submit for review

  • This PR adheres to the Definition of Done
  • Make sure there is a PR and ticket in the CNDB project updating the Converged Cassandra version
  • Use NoSpamLogger for log lines that may appear frequently in the logs
  • Verify test results on Butler
  • Test coverage for new/modified code is > 80%
  • Proper code formatting
  • Proper title for each commit staring with the project-issue number, like CNDB-1234
  • Each commit has a meaningful description
  • Each commit is not very long and contains related changes
  • Renames, moves and reformatting are in distinct commits
  • All new files should contain the IBM copyright header instead of the Apache License one (no DataStax copyright any longer)

@k-rus k-rus changed the title Rf 18137 fix warnings CNDB-18137 move linter warnings fixes from CNDB-15608 Jun 12, 2026
@k-rus
k-rus requested a review from adelapena June 12, 2026 17:19
@k-rus k-rus changed the title CNDB-18137 move linter warnings fixes from CNDB-15608 CNDB-18137 fix linter warnings in files effected by CNDB-15608 Jun 13, 2026
@k-rus
k-rus requested review from a team and removed request for adelapena June 16, 2026 07:35
@michaelsembwever

michaelsembwever commented Jun 17, 2026

Copy link
Copy Markdown

please make sure (/check) these changes (outside of sai) align with upstream.

fixing lint issues is trivial and can cause a lot of unnecessary headache on rebases.

it is better to start with fixing code style upstream first and wait for it to come back to us, then bear the rebase costs. this obviously does not apply to the sai code.

@k-rus

k-rus commented Jul 9, 2026

Copy link
Copy Markdown
Member Author

it is better to start with fixing code style upstream first and wait for it to come back to us, then bear the rebase costs. this obviously does not apply to the sai code.

@michaelsembwever to my experience it's unrealistic ask. Finding committers to review even bug fixes is extremely difficult. We need to have a better strategy how to have own changes in CC and have possibility to bring changes from upstream, which is for separate discussion.

@k-rus

k-rus commented Jul 10, 2026

Copy link
Copy Markdown
Member Author

it is better to start with fixing code style upstream first and wait for it to come back to us, then bear the rebase costs. this obviously does not apply to the sai code.

@michaelsembwever to my experience it's unrealistic ask. Finding committers to review even bug fixes is extremely difficult. We need to have a better strategy how to have own changes in CC and have possibility to bring changes from upstream, which is for separate discussion.

Also the majority of the changes were to SAI, which is not being rebased.

@k-rus
k-rus force-pushed the rf-18137-fix-warnings branch from 874b419 to 5659280 Compare July 10, 2026 08:28
@plpesvc-ds

plpesvc-ds commented Jul 10, 2026

Copy link
Copy Markdown

❌ Build ds-cassandra-pr-gate/PR-2453 rejected by Butler

2 regressions found
See build details here

Found 2 new test failures

Test Explanation Runs Upstream
o.a.c.index.sai.cql.VectorCompaction100dTest.testOneToManyCompaction[version=ec enableNVQ=false] REGRESSION 🔴⚪ 0 / 30
o.a.c.index.sai.cql.VectorSiftSmallTest.testMultiSegmentBuild[ed false] REGRESSION 🔴⚪ 0 / 30

Found 6 known test failures

@k-rus
k-rus merged commit 49ee4dc into main Jul 10, 2026
1 of 3 checks passed
@k-rus
k-rus deleted the rf-18137-fix-warnings branch July 10, 2026 13:59
djatnieks added a commit that referenced this pull request Jul 10, 2026
@djatnieks @k-rus
CNDB-18137 fix linter warnings in files effected by CNDB-15608 (#2453) (
871afcc 
#2509)

Fixes IntelliJ linter warnings in files affected during work on
CNDB-15608 to reduce warning noise:
- Fix single character strings to character constants
- Remove unused imports
- Remove unnecessary throw in method declarations
- Simplify assert in a test
- Remove undocumented fields from javadoc
- Remove unnecessary resource suppression
- Simplify string join
- Remove unused logger field
- Remove unnecessary curly braces in lambda expression
- Remove unnecessary cast

Co-authored-by: Ruslan Fomkin <ruslan.fomkin@ibm.com>
JeremiahDJordan pushed a commit that referenced this pull request Aug 14, 2026
@djatnieks @JeremiahDJordan
CNDB-18137 fix linter warnings in files effected by CNDB-15608 (#2453) (
e37d189 
#2509)

Fixes IntelliJ linter warnings in files affected during work on
CNDB-15608 to reduce warning noise:
- Fix single character strings to character constants
- Remove unused imports
- Remove unnecessary throw in method declarations
- Simplify assert in a test
- Remove undocumented fields from javadoc
- Remove unnecessary resource suppression
- Simplify string join
- Remove unused logger field
- Remove unnecessary curly braces in lambda expression
- Remove unnecessary cast

Co-authored-by: Ruslan Fomkin <ruslan.fomkin@ibm.com>

 (Rebase of commit 871afcc)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pkolaczk pkolaczk pkolaczk approved these changes
@adelapena adelapena adelapena approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@k-rus @michaelsembwever @plpesvc-ds @pkolaczk @adelapena